Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 45:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35523/40//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/40//COMMIT_MSG@28 PS40, Line 28: - Display (with libgfxinit)
Would be good to test
Done
https://review.coreboot.org/c/coreboot/+/35523/40/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35523/40/src/mainboard/acer/aspire_... PS40, Line 71: register "SaGv" = "3"
There should be an enum for SaGv values (not sure if Skylake has it)
It does, so you should use `SaGv_Enabled`:
/* * System Agent dynamic frequency configuration * When enabled memory will be trained at two different frequencies. * 0 = Disabled * 1 = FixedLow * 2 = FixedHigh * 3 = Enabled */ enum { SaGv_Disabled, SaGv_FixedLow, SaGv_FixedHigh, SaGv_Enabled, } SaGv;