Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40952 )
Change subject: nb/intel/sandybridge: Correct IOSAV register notes
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40952/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/mchbar_regs.h:
https://review.coreboot.org/c/coreboot/+/40952/1/src/northbridge/intel/sandy...
PS1, Line 23: 'closed'
Or I can s/ranges/intervals, and then both closed and endpoints are correct: […]
ah. when reading endpoints i had to think of usb...
https://review.coreboot.org/c/coreboot/+/40952/1/src/northbridge/intel/sandy...
PS1, Line 33: loaded
It's probably "loaded (from the IOSAV hardware) back into this register"
stored makes it clearer for me that it changes the contents of that register
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40952
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie384304c565f962fe58baa231c15109eb3d284aa
Gerrit-Change-Number: 40952
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 02 May 2020 19:02:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment