Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38755 )
Change subject: nb/amd/{agesa,pi}/acpi: include thermal zone ......................................................................
Patch Set 3:
(2 comments)
Please move `northbridge/amd/agesa/family14/acpi/thermal_mixin.asl` to a common location.
Commit d5e6618a (amd/fam10: Add k10temp ACPI thermal zone mixin., CB:10617) also has the comment below.
It should not be used on boards for which errata 319 (The thermal sensor of Socket F/AM2+ processors may be unreliable) is applicable. AM3 and later should be fine.
https://review.coreboot.org/c/coreboot/+/38755/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38755/3//COMMIT_MSG@11 PS3, Line 11: Tested how?
https://review.coreboot.org/c/coreboot/+/38755/3/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/38755/3/src/northbridge/amd/agesa/f... PS3, Line 96: Device (K10M) { Please use the consistent style in this file without spaces.