Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40306 )
Change subject: drivers/ipmi: Add IPMI read FRU chassis info area ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40306/5/src/drivers/ipmi/ipmi_fru.c File src/drivers/ipmi/ipmi_fru.c:
https://review.coreboot.org/c/coreboot/+/40306/5/src/drivers/ipmi/ipmi_fru.c... PS5, Line 109: if (!data2str((const uint8_t *)data_ptr, *string, length)) {
If this fails, that means the data obtained from BMC has issue. […]
Done
https://review.coreboot.org/c/coreboot/+/40306/5/src/drivers/ipmi/ipmi_fru.c... PS5, Line 115: printk(BIOS_ERR, "string length is 0.\n");
Let's print out __func__, __line__ to assist with debugging. […]
Done