Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31007 )
Change subject: nb/intel/i945: Check if interleaved even if rank #4 size is zero ......................................................................
Patch Set 8: Code-Review+1
(4 comments)
https://review.coreboot.org/#/c/31007/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31007/8//COMMIT_MSG@18 PS8, Line 18: + 1?
https://review.coreboot.org/#/c/31007/8//COMMIT_MSG@27 PS8, Line 27: If channel0 is not populated, raminit will fail. : If RAM is 533, raminit will fail. : I think that northbridge/intel/i945/rcven.c needs some inverstigation : and probably a fix. That's all unrelated?
https://review.coreboot.org/#/c/31007/8/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/31007/8/src/northbridge/intel/i945/raminit.c... PS8, Line 2581: Why remove this blank line?
https://review.coreboot.org/#/c/31007/8/src/northbridge/intel/i945/raminit.c... PS8, Line 2557: Why add a blank line?