Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35409 )
Change subject: arch/arm: Allow program loading of Linux kernels
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35409/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35409/3//COMMIT_MSG@18
PS3, Line 18: Boots to initramfs.
What Linux version did you use?
Is anything needed here?
https://review.coreboot.org/c/coreboot/+/35409/4/src/arch/arm/boot.c
File src/arch/arm/boot.c:
https://review.coreboot.org/c/coreboot/+/35409/4/src/arch/arm/boot.c@35
PS4, Line 35: * Switch to arm instruction set. We might be running in thumb2 mode.
nit: technically could just do a blx r3 and that will automatically jump back to Arm mode (because b […]
Is anything needed here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35409
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0dcc26d647941de71669345911ba288341b834b
Gerrit-Change-Number: 35409
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 12:20:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment