Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47599 )
Change subject: arch/x86: Move prologue to .init section
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47599/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47599/4//COMMIT_MSG@17
PS4, Line 17: Description of .init section for ELF:
:
: This section holds executable instructions that contribute to the
: process initialization code. When a program starts to run, the
: system arranges to execute the code in this section before calling the
: main program entry point (called main for C programs).
I wonder if we could first rename existing .text._start and .text.stage_entry both to .init. […]
For x86 bootblocks .text._start must be at most 64 KiB from .reset. Or in other words, C_ENV_BOOTBLOCK_SIZE must not grow over 64 KiB while latest soc/intel have reached 48 KiB already.
There is followup CB:47970 that locates this newly introduced .init after .text.* rules.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If32518b1c19d08935727330314904b52a246af3c
Gerrit-Change-Number: 47599
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Dec 2020 06:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment