Attention is currently required from: Angel Pons, Fabian Meyer, Paul Menzel.
Nico Huber has posted comments on this change by Fabian Meyer. ( https://review.coreboot.org/c/coreboot/+/82203?usp=email )
Change subject: mb/asrock: Add SPR 1S server board ASRock Rack SPC741D8-2L2T/BCM
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/asrock/spc741d8/ramstage.c:
https://review.coreboot.org/c/coreboot/+/82203/comment/51d39674_6fcc0896?usp... :
PS3, Line 15: // stub for EDK2
SOFTWARE_I2C, however, seems to be designed as a developer option, nothing that
should be selected by a driver (expect bus number conflicts if some other driver
tries to use a SoC's I2C bus 0).
lol, I just realized that's what the driver already does... so forget what I
said about selecting it in the board Kconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82203?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I84b170669873f1a168ea2b7e3be1d6071e811fa5
Gerrit-Change-Number: 82203
Gerrit-PatchSet: 9
Gerrit-Owner: Fabian Meyer
fabian@meyfa.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fabian Meyer
fabian@meyfa.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 25 May 2024 12:51:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Fabian Meyer
fabian@meyfa.net