Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39703 )
Change subject: mb/pcengines/apu2: add reset logic for PCIe slots
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39703/1/src/mainboard/pcengines/apu...
File src/mainboard/pcengines/apu2/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/39703/1/src/mainboard/pcengines/apu...
PS1, Line 28: static AGESA_STATUS board_GnbPcieSlotReset (UINT32 Func, UINTN Data, VOID *ConfigPtr);
space prohibited between function name and open parenthesis '('
then... maybe use PciEx? This would keep the alignment for the parameters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ff7db6ff85cce45b84729be905e6c895a24f6f2
Gerrit-Change-Number: 39703
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 23 Mar 2020 18:00:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment