Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/29575
Change subject: ec/google/chromeec: Configure EC_SYNC_IRQ as level triggered ......................................................................
ec/google/chromeec: Configure EC_SYNC_IRQ as level triggered
EC_SYNC_IRQ from EC to host is level-triggered in practice and configuring it as edge-triggered on the host results in host missing events if there are multiple events queued on the EC side. This is because Linux kernel driver reads one event per irq and the EC does not de-assert the interrupt line until all events are drained out. This results in event queue being filled up completely on the EC and the host failing to see any of those events.
This change configures EC_SYNC_IRQ as level triggered to allow the host to read events from the the EC as long as the line is asserted.
BUG=b:118949877
Change-Id: Id3fcfa0445f83865d57975a7bbc179dca047ba4c Signed-off-by: Furquan Shaikh furquan@google.com --- M src/ec/google/chromeec/acpi/cros_ec.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/29575/1
diff --git a/src/ec/google/chromeec/acpi/cros_ec.asl b/src/ec/google/chromeec/acpi/cros_ec.asl index befd5a7..a5f9202 100644 --- a/src/ec/google/chromeec/acpi/cros_ec.asl +++ b/src/ec/google/chromeec/acpi/cros_ec.asl @@ -25,7 +25,7 @@ #ifdef EC_ENABLE_SYNC_IRQ Name (_CRS, ResourceTemplate () { - Interrupt (ResourceConsumer, Edge, ActiveLow, Exclusive) + Interrupt (ResourceConsumer, Level, ActiveLow, Exclusive) { EC_SYNC_IRQ }