build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42193 )
Change subject: soc/mediatek/mt8183: Fix some programming errors of DRAMC setting ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/42193/3/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/42193/3/src/soc/mediatek/mt8183/dra... PS3, Line 893: clrsetbits32(&ch[0].phy.shu[0].b[0].dq[7], trailing whitespace
https://review.coreboot.org/c/coreboot/+/42193/3/src/soc/mediatek/mt8183/dra... PS3, Line 894: (0x3 << 4) | (0x1 << 7) | (0x1 << 13), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/42193/3/src/soc/mediatek/mt8183/dra... PS3, Line 894: (0x3 << 4) | (0x1 << 7) | (0x1 << 13), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42193/3/src/soc/mediatek/mt8183/dra... PS3, Line 952: clrsetbits32(&ch[0].phy.shu[0].b[0].dq[7], trailing whitespace
https://review.coreboot.org/c/coreboot/+/42193/3/src/soc/mediatek/mt8183/dra... PS3, Line 953: (0x3 << 4) | (0x1 << 7) | (0x1 << 13), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/42193/3/src/soc/mediatek/mt8183/dra... PS3, Line 953: (0x3 << 4) | (0x1 << 7) | (0x1 << 13), please, no spaces at the start of a line