[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size

[Felix Held (Code Review)]

Attention is currently required from: Martin Roth, Furquan Shaikh, Marshall Dawson, Tim Wawrzynczak, Meera Ravindranath, Andrey Petrov, Patrick Rudolph, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50241 )

Change subject: drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size
......................................................................

Patch Set 4:

(1 comment)

File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/c/coreboot/+/50241/comment/a7a7768a_a945427f 
PS4, Line 251: hope
> We shouldn't have to hope - This should be required of the UPD structure.

sure, after the first FSP release the UPDs should be treated as append-only data structure, but there's no versioning and checking of the UPD data structures. Just checking the version of the whole FSP binary should be sufficient for that though, but I don't think that we check on Picasso right now if we're using the FSP binaries with the right major version number. I think I still have an open bug for that in the internal bug tracker. but yeah, the wording was intentional here