Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43303 )
Change subject: soc/amd/common: Use SPI settings from Kconfig options ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43303/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/chip.h:
https://review.coreboot.org/c/coreboot/+/43303/1/src/soc/amd/common/block/in... PS1, Line 7: #include <amdblocks/spi.h> Remove this include?
https://review.coreboot.org/c/coreboot/+/43303/1/src/soc/amd/common/block/sp... File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/43303/1/src/soc/amd/common/block/sp... PS1, Line 57: if (CONFIG(SPI_SPEED_33M)) Should all these be else if? compiler will do dead code optimization regardless and just leave the assignment, but these options are mutually exclusive. We should treat them as such. Same for the modes below.