Attention is currently required from: Deepti Deshatty, Shelley Chen, Varshit Pandya, Vijay P Hiremath.
Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81207?usp=email )
Change subject: mb/google/brox: Enable PMC pins to work with PD
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81207/comment/f622757b_41eddb57 :
PS1, Line 7: Enable PMC pins to work with PD
Nit: Enable SMLINK1 interface
Done
https://review.coreboot.org/c/coreboot/+/81207/comment/b6c6047b_1228c807 :
PS1, Line 8:
Nit: Enabled SMLINK1 interface to enable to PMC to PD communication to configure the Type-C muxes.
Done
https://review.coreboot.org/c/coreboot/+/81207/comment/4c173817_18316e9d :
PS1, Line 9: For PMC-PD communication we need to enable 3 pins.
Hey Deepti, […]
These pins are configured based on HW team's brox sheet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81207?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia678d291e7a14aefe09026e70478fea3f68c8e10
Gerrit-Change-Number: 81207
Gerrit-PatchSet: 1
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Comment-Date: Thu, 28 Mar 2024 06:49:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit Pandya
pandyavarshit@gmail.com
Comment-In-Reply-To: Vijay P Hiremath
vijay.p.hiremath@intel.com
Comment-In-Reply-To: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-MessageType: comment