Attention is currently required from: Ravi kumar, Furquan Shaikh, Arthur Heymans, Prasad Malisetty. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57615 )
Change subject: libpayload: Add support for PCI MMIO CONFIG access. ......................................................................
Patch Set 37:
(6 comments)
File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/57615/comment/1be1e517_95211701 PS29, Line 285: onfig MMCONF_SUPPORT : bool "MMCONF support for drivers" : depends on SERIAL_CONSOLE : default n : : config QC_MMCONF_SUPPORT : bool "QC MMCONF support for drivers" : depends on SERIAL_CONSOLE : default n :
Please use MMIO instead of MMCONF as this can get confused with ECAM per the discussion in https://r […]
This is still an issue
File payloads/libpayload/drivers/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/57615/comment/dd29b936_afb3ec57 PS37, Line 34: ifeq ($(CONFIG_LP_MMCONF_SUPPORT),y) : libc-$(CONFIG_LP_MMCONF_SUPPORT) += pci_mmio_ops.c : libc-$(CONFIG_LP_QC_MMCONF_SUPPORT) += qc_pci_mmio_ops.c These Kconfigs should all be MMIO and not MMCONF right?
File payloads/libpayload/drivers/pci_io_ops.c:
https://review.coreboot.org/c/coreboot/+/57615/comment/5c29dbe5_b64ff217 PS29, Line 70: pcidev_t *dev)
Can we get rid of all the space changes in this file so that we just see the functional changes? My […]
This is still not fixed.
File payloads/libpayload/drivers/pci_mmio_ops.c:
https://review.coreboot.org/c/coreboot/+/57615/comment/d28a514d_eb4af08a PS29, Line 74: pcidev_t *dev)
Please get rid of the extra line changes in this file (from here down). […]
still an issue.
File payloads/libpayload/drivers/qc_pci_mmio_ops.c:
https://review.coreboot.org/c/coreboot/+/57615/comment/a3db92a1_7f8e9f75 PS37, Line 107: cfg_address = (void*) pci_mmio_info->config_base;
"(void*)" should be "(void *)"
Please fix.
File payloads/libpayload/include/qc_pci.h:
https://review.coreboot.org/c/coreboot/+/57615/comment/e3727a00_71e76683 PS37, Line 70: #endif
trailing whitespace
Please fix.