Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32283 )
Change subject: soc/intel/../../timer: Calculate TSC frequency based on CPUID 0x15 ......................................................................
Patch Set 4:
(4 comments)
In the header files, you add a lot of new macros also for older generations. Please mention in the commit message, from what generation on method 2 should be used.
https://review.coreboot.org/#/c/32283/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32283/3//COMMIT_MSG@10 PS3, Line 10: norminal nominal?
https://review.coreboot.org/#/c/32283/3//COMMIT_MSG@18 PS3, Line 18: TEST=Calculate TSC frequency using below methods What board is this?
https://review.coreboot.org/#/c/32283/3//COMMIT_MSG@25 PS3, Line 25: mSec SI unit is ms.
https://review.coreboot.org/#/c/32283/3//COMMIT_MSG@25 PS3, Line 25: Method 2 actually reduce ~25mSec of boot performance time. Awesome. Thank you for documenting that.