Attention is currently required from: Christian Walter, Felix Held, Jérémy Compostella, Michał Żygowski.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82057?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/crb,pc80/tpm: Add crb and pc80 prefixes to chip configs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82057/comment/a2c9657a_b803c29b :
PS1, Line 9: Avoid tpm_config_t type redefinition by adding crb and pc80 prefixes.
IIRC, coreboot's coding style discourages the use of typedefs. I would drop the typedefs altogether, especially considering how tiny this change is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82057?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id41717e265362303a17745303a907c9c8f4f4e12
Gerrit-Change-Number: 82057
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 28 Apr 2024 09:47:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment