Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46839 )
Change subject: arch/x86/spinlock: Drop linker section in inline assembly
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46839/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46839/2//COMMIT_MSG@11
PS2, Line 11: might
It does cause linker errors as those functions aren't garbage collected. […]
A function not being garbage collected shouldn't cause an error. What is the error exactly? It's hard to understand what the actual problem is based on the description. Could you please provide more information in the commit description so it's clear that there's a real issue that needs to be resolved?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4f5a8f4aec0e05bc35359b334845c177867d4a4
Gerrit-Change-Number: 46839
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 28 Oct 2020 17:33:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment