Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )
Change subject: tigerlake: add unique acpi device ids for dptf ......................................................................
Patch Set 5:
(8 comments)
https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@9 PS4, Line 9: Tigerlake
Tiger Lake
Done
https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@10 PS4, Line 10: g
accordingly
Done
https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@11 PS4, Line 11:
Please mention that in the commit message, that the Linux kernel driver expects these.
Ack
https://review.coreboot.org/c/coreboot/+/42040/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/42040/5/src/mainboard/google/voltee... PS5, Line 60: Tigerlake
Tiger Lake
Ack
https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... PS5, Line 3: Tigerlake
Tiger Lake
Ack
https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... PS5, Line 5:
space, not tab
Ack
https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... PS5, Line 7:
space, not tab
Ack
https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... PS5, Line 9:
space, not tab
Ack