Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42208 )
Change subject: soc/amd/picasso/bootblock: Clear BSS ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42208/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42208/1//COMMIT_MSG@9 PS1, Line 9: The PSP does not currently reload bootblock on S3 resume. This means the Sorry for being ignorant about the bootflow, but why would it be useful to reload the bootblock? (bootblock is `bootblock` in CBFS, right?)
https://review.coreboot.org/c/coreboot/+/42208/1//COMMIT_MSG@9 PS1, Line 9: This means the : memory retains the previous values from the run. What visible problem does that cause? Resume problems?
https://review.coreboot.org/c/coreboot/+/42208/1//COMMIT_MSG@12 PS1, Line 12: Please mention, that this does not noticeably affect the resume time.
https://review.coreboot.org/c/coreboot/+/42208/1//COMMIT_MSG@14 PS1, Line 14: staic static
https://review.coreboot.org/c/coreboot/+/42208/1/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/pre_c.S:
https://review.coreboot.org/c/coreboot/+/42208/1/src/soc/amd/picasso/bootblo... PS1, Line 21: clear Clear