Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42191 )
Change subject: sb/intel/i82801gx: Use PCI bitwise ops ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42191/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/azalia.c:
https://review.coreboot.org/c/coreboot/+/42191/2/src/southbridge/intel/i8280... PS2, Line 201: ~0x00ff0000
it will give '0xFFFFFFFFFF00FFFF' :) […]
This is 32-bit code, and the negation implicitly promotes to int only, which is 32-bit.
In any case, this causes troubles with smaller types (which then need a cast) so it's going to be easier to do `Unset_And_Set_Mask` style operations (as in libgfxinit), which do not need a negation on the and-mask.