EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35206 )
Change subject: lib/spd_bin: Extend DDR4 spd information ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35206/7/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/35206/7/src/lib/spd_bin.c@43 PS7, Line 43: switch (dram_type) {
switch and case should be at the same indent
Done
https://review.coreboot.org/c/coreboot/+/35206/7/src/lib/spd_bin.c@60 PS7, Line 60: if (is_memory_type_ddr4(dram_type))
that open brace { should be on the previous line
Done
https://review.coreboot.org/c/coreboot/+/35206/7/src/lib/spd_bin.c@66 PS7, Line 66: else
else should follow close brace '}'
Done
https://review.coreboot.org/c/coreboot/+/35206/7/src/lib/spd_bin.c@148 PS7, Line 148: printk(BIOS_INFO, "%s\n",spd_get_module_type_string(type));
space required after that ',' (ctx:VxV)
Done