Attention is currently required from: Keith Hui, Paul Menzel.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76775?usp=email )
Change subject: Documentation: Bring back abuild documentation ......................................................................
Patch Set 3:
(7 comments)
Patchset:
PS3: Awesome write-up. Thanks!
File Documentation/util/abuild/index.md:
https://review.coreboot.org/c/coreboot/+/76775/comment/c025afdf_f388e776 : PS3, Line 4: This utility is a great tool to check whether your coreboot tree compiles for one or all targets. The documentation guidelines request that the text be wrapped at 72 characters. https://doc.coreboot.org/getting_started/writing_documentation.html#basic-an...
Well, what it actually says is "Running text should have a visible width of about 72 chars." which is hard to do automatically, so I just recommend using a tool to wrap it at 72 characters.
Personally, I think that's too short, but that's the current standard.
https://review.coreboot.org/c/coreboot/+/76775/comment/b7bda734_591cccaf : PS3, Line 18: end up in the coreboot-builds/ Maybe "will by default end up in your current folder under the coreboot-builds directory."
It's probably implied, and I'm the only one thinking this way. :)
https://review.coreboot.org/c/coreboot/+/76775/comment/b8027e17_82ce5ca3 : PS3, Line 41: Extra whitespace
https://review.coreboot.org/c/coreboot/+/76775/comment/81e5bf69_babc3a8e : PS3, Line 48: fully working image I'd be careful with this. While it's our stated goal for this to be true, it's unfortunately not true much of the time. This is only true if the default config is the booting config. Many platforms leave out pieces that need to be added to the build in one spot or another.
https://review.coreboot.org/c/coreboot/+/76775/comment/b7c4bee9_40386bdf : PS3, Line 116: ### Build non-default configurations This might be a good spot to give the usage of the -K argument.
If you created a file called "myconfig" with just the line:
``` # CONFIG_USE_NATIVE_RAMINIT is not set ```
and ran `abuild -K myconfig`, you'd get that setting applied to anything that abuild builds.
https://review.coreboot.org/c/coreboot/+/76775/comment/9e553995_dcd465a3 : PS3, Line 190: Note that you must replace all hyphens in the variant name with underscores for this to : work. There is a [patch](https://review.coreboot.org/c/coreboot/+/41918) submitted that : attempts to correct this behaviour. I just gave this patch a +2. Sorry, I hadn't noticed it before.