Attention is currently required from: Simon Chou, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71965 )
Change subject: soc/intel/xeon_sp/chip_common.c: Add support for SPR
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/xeon_sp/chip_common.c:
https://review.coreboot.org/c/coreboot/+/71965/comment/3b073ea2_bca2c82e
PS2, Line 519: max_subordinate
Yes this depends on CB:59395, should we make it depends on it?
[CB:59395] needs to be merged in first; Arthur, please let us know if there is anything we could do to help.
In general, spr-upstream are dependents for str-enable, some are hard dependents (like in this case), others are softer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71965
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica3c61493a0ff6c699b500f30788b2cf5a06c250
Gerrit-Change-Number: 71965
Gerrit-PatchSet: 3
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 16 Jan 2023 16:40:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment