Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41835 )
Change subject: soc/amd/picasso/acpi: Remove hardcoded FCH IRQ numbers ......................................................................
Uploaded patch set 2.
(11 comments)
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... File src/soc/amd/picasso/acpi/sb_fch.asl:
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 29: (
nit: space before (
Done
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 30: {
space before {
Done
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 30: ResourceTemplate
Name (RBUF, ResourceTemplate() { […]
Done
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 30: local0
Local0?
Done
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 39: (
space before (
Done
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 41: =
spaces around =
Done
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 43: =
spaces around =
Done
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 46: (
space before (
Done
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 46: {
space before {
Done
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 50: (
space before (
Done
https://review.coreboot.org/c/coreboot/+/41835/1/src/soc/amd/picasso/acpi/sb... PS1, Line 50: local0
If you change to RBUF, then this will have to be updated to RBUF.
Done