[coreboot-gerrit] Change in ...coreboot[master]: board/kukui: Support ADC value for NC

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32353 )

Change subject: board/kukui: Support ADC value for NC
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32353/4/src/mainboard/google/kukui/boardid.c 
File src/mainboard/google/kukui/boardid.c:

https://review.coreboot.org/#/c/32353/4/src/mainboard/google/kukui/boardid.c... 
PS4, Line 91: 		assert(0);
> Why is the assert still needed?

I think we still want the device to hang and fail for early/debug builds (to catch real build failure), but probably not failing in release products. So an assert is added.