Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44703 )
Change subject: soc/mediatek/mt8192: Do EMI init before dram calibration
......................................................................
Patch Set 47:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44703/46/src/soc/mediatek/mt8192/em...
File src/soc/mediatek/mt8192/emi.c:
https://review.coreboot.org/c/coreboot/+/44703/46/src/soc/mediatek/mt8192/em...
PS46, Line 13: write32
These EMI register settings are HW related, they are from internal EMI datasheet, i add a descriptio […]
Can you add the name of that internal datasheet? No need to publish, but we want to have a reference so it's more clear, and will be better than simply "default settings".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b778698a09c999252fef3153ac1e869ea9d90cd
Gerrit-Change-Number: 44703
Gerrit-PatchSet: 47
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Dec 2020 08:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xi Chen
xixi.chen@mediatek.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment