Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 )
Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x...
File src/mainboard/supermicro/x10slm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x...
PS12, Line 59: register "gen4_dec" = "0x00000000"
0x2e8 isn't routed to LPC but enabled on aspeed
0x2e is not the aspeed, but I assume that you mean the nct6776.
In that case I agree that I could disable SUART4 on there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70
Gerrit-Change-Number: 34905
Gerrit-PatchSet: 13
Gerrit-Owner: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Oct 2019 08:52:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment