Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61576 )
Change subject: util/ifdtool: add platform_v1 to reduce common ifd tool change ......................................................................
util/ifdtool: add platform_v1 to reduce common ifd tool change
TGL, ADL has same ifd tool and future platforms may also use same tool. As TGL, ADL use own names for enabling ifd tool, we need to update ifd tool code for new platforms even if ifd tool is not changed. For avoid unnessary change, use generic platform name(platform_v1) for support future platforms.
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22 --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/61576/1
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index ca5d3b8..061d352 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -224,6 +224,7 @@ return CHIPSET_300_SERIES_CANNON_POINT; case PLATFORM_TGL: case PLATFORM_ADL: + case PLATFORM_V1: return CHIPSET_500_600_SERIES_TIGER_ALDER_POINT; case PLATFORM_ICL: return CHIPSET_400_SERIES_ICE_POINT; @@ -253,6 +254,7 @@ PLATFORM_EHL, PLATFORM_ADL, PLATFORM_SKLKBL, + PLATFORM_V1, }; unsigned int i;
@@ -1178,6 +1180,7 @@ case PLATFORM_JSL: case PLATFORM_EHL: case PLATFORM_ADL: + case PLATFORM_V1: /* CPU/BIOS can read descriptor and BIOS. */ fmba->flmstr1 |= (1 << REGION_DESC) << rd_shift; fmba->flmstr1 |= (1 << REGION_BIOS) << rd_shift; @@ -1635,6 +1638,7 @@ " ehl - Elkhart Lake\n" " glk - Gemini Lake\n" " icl - Ice Lake\n" + " pv1 - Intel platform v1(intel core 11th and later)\n" " jsl - Jasper Lake\n" " sklkbl - Sky Lake/Kaby Lake\n" " tgl - Tiger Lake\n" @@ -1891,6 +1895,8 @@ platform = PLATFORM_TGL; } else if (!strcmp(optarg, "adl")) { platform = PLATFORM_ADL; + } else if (!strcmp(optarg, "pv1")) { + platform = PLATFORM_V1; } else { fprintf(stderr, "Unknown platform: %s\n", optarg); exit(EXIT_FAILURE); diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index 4f63e20..d00eb793 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -58,6 +58,7 @@ PLATFORM_SKLKBL, PLATFORM_TGL, PLATFORM_ADL, + PLATFORM_V1, };
#define LAYOUT_LINELEN 80