Attention is currently required from: Arthur Heymans, ron minnich. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry ......................................................................
Patch Set 5:
(1 comment)
File util/cbfstool/linux_trampoline.c:
https://review.coreboot.org/c/coreboot/+/62574/comment/d5bcb3bc_704065a5 PS4, Line 1: /* This file is automatically generated. Do not manually change */ Totally off-topic, but should we automate this a bit better (so that we no longer have to check in an opaque hex array and just hope the committer did the right thing)? This sort of thing can be done neatly with the `.incbin` assembly directive (e.g. see https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/rockch... and https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/rockch... for an example).