[coreboot-gerrit] Change in coreboot[master]: device/mmio.h: Add bit field helpers

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35463 )

Change subject: device/mmio.h: Add bit field helpers
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35463/3/src/include/device/mmio.h 
File src/include/device/mmio.h:

https://review.coreboot.org/c/coreboot/+/35463/3/src/include/device/mmio.h@5... 
PS3, Line 59: usually inside a register
> Missing )

Done

https://review.coreboot.org/c/coreboot/+/35463/3/src/include/device/mmio.h@6... 
PS3, Line 61:  * DEFINE_BITFIELD(name, start, end);
> I somehow think "start >= end" is a little bit counter-intuitive. […]

Done