Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40935 )
Change subject: arch/x86: Change power_res_dev_states[] to be non-static ......................................................................
arch/x86: Change power_res_dev_states[] to be non-static
Jenkins complains that power_res_dev_states[] should be a const pointer since it is marked static. However, this doesn't really need to be static. Hence, the change drops static keyword.
BUG=b:155428745
Change-Id: Ice2fff6ab3bcd72a059bc905b7462a681f2e6aaf Signed-off-by: Furquan Shaikh furquan@google.com --- M src/arch/x86/acpi_device.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/40935/1
diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c index b4016ef..653e124 100644 --- a/src/arch/x86/acpi_device.c +++ b/src/arch/x86/acpi_device.c @@ -527,7 +527,7 @@ /* PowerResource() with Enable and/or Reset control */ void acpi_device_add_power_res(const struct acpi_power_res_params *params) { - static const char *power_res_dev_states[] = { "_PR0", "_PR3" }; + const char *power_res_dev_states[] = { "_PR0", "_PR3" }; unsigned int reset_gpio = params->reset_gpio ? params->reset_gpio->pins[0] : 0; unsigned int enable_gpio = params->enable_gpio ? params->enable_gpio->pins[0] : 0; unsigned int stop_gpio = params->stop_gpio ? params->stop_gpio->pins[0] : 0;