[coreboot-gerrit] Change in coreboot[master]: sc7180: Add QUPv3 FW load & config

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 )

Change subject: sc7180: Add QUPv3 FW load & config
......................................................................

Patch Set 41:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/qu... 
File src/soc/qualcomm/sc7180/qupv3_config.c:

https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/qu... 
PS40, Line 53: 
One more thing I just noticed, it would be good to have *some* kind of sanity checking here to make sure the file we have is not complete garbage before we start trying to use it. It looks like you have a magic number ('SEFW') at the top of the header, can you check that? (If there's some way to check that the protocol matches, that would be even better.)