Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39004 )
Change subject: [WIP]drivers: Replace set_vbe_mode_info_valid
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39004/1/src/drivers/aspeed/common/a...
File src/drivers/aspeed/common/ast_mode_corebootfb.c:
https://review.coreboot.org/c/coreboot/+/39004/1/src/drivers/aspeed/common/a...
PS1, Line 256: }
Log the failure case?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95d1d62385a201c68c6c2527c023ad2292a235c5
Gerrit-Change-Number: 39004
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 19 Feb 2020 12:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment