Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36300 )
Change subject: vboot: use vboot persistent context ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36300/1/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/1/src/security/vboot/common.c... PS1, Line 55: if (wd->buffer_offset == ALIGN_UP(sizeof(*wd), 16)) {
I agree with Julius -- I'd prefer to encapsulate this in one function without having to set it up ex […]
I take that back... it seems that vboot_get_recovery_reason_shared_data() is called even before verstage logic runs. I think it would be much safer to include everything in one function, so we don't have to worry about the order in which init() and get() are called...
But I don't think we can check !verification_should_run() -- this breaks the case of VBOOT_STARTS_IN_ROMSTAGE.