Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44480 )
Change subject: mb/google/zork: Switch zork to use spd_tools ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44480/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44480/3//COMMIT_MSG@12 PS3, Line 12: TEST=Boot ezkinil I realize this is still WIP - but you'll need to do a more comprehensive text than just Ezkinil.
https://review.coreboot.org/c/coreboot/+/44480/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44480/3/src/mainboard/google/zork/v... PS3, Line 52: APCB_X2_CHANNELS = true document what this does as well like on line 46?
https://review.coreboot.org/c/coreboot/+/44480/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/morphius/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44480/3/src/mainboard/google/zork/v... PS3, Line 1: ## SPDX-License-Identifier: GPL-2.0-or-later does this list collapse at all if we don't support board version 0x1?