Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45435 )
Change subject: nb/intel/gm45: Guard macro parameters ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45435/comment/731663a8_efad4cf5 PS4, Line 11: the resulting coreboot image. The reasons have not been determined.
Simple: because it's broken. It happens exactly what the brackets […]
CB:49261
File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/c/coreboot/+/45435/comment/8f5fc85f_da5c2bad PS4, Line 234: #define MCHBAR8(x) *((volatile u8 *)(DEFAULT_MCHBAR + (x)))
As mentioned on IRC, there probably is no operator that could take […]
Done
https://review.coreboot.org/c/coreboot/+/45435/comment/36acc779_8abfafc2 PS4, Line 267: \
looks like this was manually aligned to match the next line
Done