10 Feb
2019
10 Feb
'19
6:21 p.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31303 )
Change subject: device/pci_early.c: Drop some guards ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31303/2/src/console/init.c File src/console/init.c:
https://review.coreboot.org/#/c/31303/2/src/console/init.c@78 PS2, Line 78: !ENV_SMM && !ENV_RAMSTAGE) would it not fit on one line?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31303
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58a6348750d240aa6024599f7b1af1449f31e8ac
Gerrit-Change-Number: 31303
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 10 Feb 2019 18:21:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment