build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46684 )
Change subject: tests: Add test region and symbol macros to <tests/test.h> ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46684/1/tests/include/tests/test.h File tests/include/tests/test.h:
https://review.coreboot.org/c/coreboot/+/46684/1/tests/include/tests/test.h@... PS1, Line 20: #define TEST_SYMBOL(symbol, address) asm ( ".set " #symbol ", " #address "\n\t.globl " #symbol ) space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/46684/1/tests/include/tests/test.h@... PS1, Line 20: #define TEST_SYMBOL(symbol, address) asm ( ".set " #symbol ", " #address "\n\t.globl " #symbol ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/46684/1/tests/include/tests/test.h@... PS1, Line 20: #define TEST_SYMBOL(symbol, address) asm ( ".set " #symbol ", " #address "\n\t.globl " #symbol ) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46684/1/tests/include/tests/test.h@... PS1, Line 28: #define TEST_REGION(region, size) uint8_t _##region[size]; TEST_SYMBOL(_e##region, _##region + size) line over 96 characters