Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33282 )
Change subject: spi_flash: Make .read() callback optional
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33282/4/src/drivers/spi/spi_flash.c
File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/#/c/33282/4/src/drivers/spi/spi_flash.c@104
PS4, Line 104: CONFIG(SPI_FLASH_NO_FAST_READ)
Outside the scope of this patch: Is the only use case for this Intel SPI controllers that are locked down and cannot use fast_read? If so a callback that bases the decision on spispeed and in the Intel case the opmenu + lockdown state could be better?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2096a3ce619767b41b1b0c0c2b8e95b2bd90a419
Gerrit-Change-Number: 33282
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 07 Jun 2019 09:29:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment