Attention is currently required from: Sean Rhodes, Andy Pont.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62514 )
Change subject: ec/starlabs/merlin: Don't report a battery capacity higher than design capacity
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
Out of curiosity, where does the value for B1FC come from? I guess it comes from the EC, which either calculates the value or gets it from a smart battery controller.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62514
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3e4769c809b69e0a237b5f043e6c41c12d53752
Gerrit-Change-Number: 62514
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Comment-Date: Wed, 02 Mar 2022 11:04:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment