[coreboot-gerrit] Change in coreboot[master]: mb/intel/adlrvp: Add ADL-P romstage mainboard code

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46091 )

Change subject: mb/intel/adlrvp: Add ADL-P romstage mainboard code
......................................................................

Patch Set 9: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/46091/9/src/mainboard/intel/adlrvp/... 
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:

https://review.coreboot.org/c/coreboot/+/46091/9/src/mainboard/intel/adlrvp/... 
PS9, Line 22: BIT_2_0
BOARD_ID_MASK maybe?

https://review.coreboot.org/c/coreboot/+/46091/7/src/mainboard/intel/adlrvp/... 
File src/mainboard/intel/adlrvp/variants/adlrvp_p/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/46091/7/src/mainboard/intel/adlrvp/... 
PS7, Line 8: register "SaGv" = "SaGv_Disabled"
> I'm totally agree with you Angel, Sagv shouldn't need to manage from MB devicetree as this is more S […]

Sure, I can give it a try.