Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35312 )
Change subject: soc/intel/skylake: Fix crash in MP init
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35312/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35312/1//COMMIT_MSG@14
PS1, Line 14: To fully migitate L1TF or E2E attacks, hyperthreading should be disabled
do we really want to disable HT by default?
ah, well, sgx_enable only comes into effect when SOC_INTEL_COMMON_BLOCK_SGX=y, so SGX and HT are controllable by config FSP_HYPERTHREADING, which is on by default, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35312
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7102da028a449c60ca700b3f9ccda9017aa6d6b5
Gerrit-Change-Number: 35312
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner
Gerrit-Comment-Date: Wed, 18 Sep 2019 14:11:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment