Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34166 )
Change subject: soc/intel/{cnl,icl}: Always use CAR NEM enhanced by default
......................................................................
Patch Set 3:
Folks, I know now that I shouldn't have used the word `insane`
in the commit message. I looked it up, realized that it is a much
stronger word than I expected and changed it immediately.
But... spending hours with a review that fixes a regression that
only made it through the review process because the reviewing
party got their comforting cushion in the patch? That really shows
that something is wrong in the community. And then covering up for
the tension in the community with an adapted commit message? I
think that would even make it worse.
Please, don't ignore tension in the community. Please, make it
visible wherever you can! If we cover it up, we can never learn
from past faults. And I think we all have to learn and hope we
will.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34166
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a880f3093887628ce6bc9c39758e43688345713
Gerrit-Change-Number: 34166
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Teo Boon Tiong
boon.tiong.teo@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 12 Jul 2019 13:56:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment