Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44210 )
Change subject: cpu/intel/common: Add `intel_ht_supported` function
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44210/2/src/cpu/intel/common/hypert...
File src/cpu/intel/common/hyperthreading.c:
https://review.coreboot.org/c/coreboot/+/44210/2/src/cpu/intel/common/hypert...
PS2, Line 6: include <types.h>
??
When adding a single header, I'd rather include more than necessary than accidentally rely on indirect inclusion. Especially for types.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c0378c4042dec39c8c86c1d2339a5cbcfe78e3
Gerrit-Change-Number: 44210
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Aug 2020 10:04:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment