Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47800 )
Change subject: soc/mediatek/mt8192: add i2c driver support ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47800/3//COMMIT_MSG Commit Message:
PS3:
Then please abandon CB:46573, and add this patch to ToT.
Ack
https://review.coreboot.org/c/coreboot/+/47800/3/src/soc/mediatek/mt8192/i2c... File src/soc/mediatek/mt8192/i2c.c:
https://review.coreboot.org/c/coreboot/+/47800/3/src/soc/mediatek/mt8192/i2c... PS3, Line 145: static void mtk_i2c_speed_init(uint8_t bus)
Different soc has some different register, such as: ltiming, so we need a place to initialize them s […]
Ack
https://review.coreboot.org/c/coreboot/+/47800/3/src/soc/mediatek/mt8192/i2c... PS3, Line 156: (400 * KHz * sample_div * 2) * clock_div);
The previous codes follow the 80 characters rule. […]
Ack
https://review.coreboot.org/c/coreboot/+/47800/3/src/soc/mediatek/mt8192/i2c... PS3, Line 169: clock_div - 1);
The previous codes follow the 80 characters rule. […]
Ack