10 May
2019
10 May
'19
3:49 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32737 )
Change subject: nb/intel/snb: Drop NORTHBRIDGE_INTEL_IVYBRIDGE ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32737/1/src/northbridge/intel/sandybridge/Kc... File src/northbridge/intel/sandybridge/Kconfig:
https://review.coreboot.org/#/c/32737/1/src/northbridge/intel/sandybridge/Kc... PS1, Line 29:
its absence makes no difference? Do we still need the symbol?
See src/cpu/intel/model_206ax/Kconfig
CPU_INTEL_MODEL_306AX can be removed as well.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32737
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1e33c77f44a66baacba375cbb2aeb71effb7b76
Gerrit-Change-Number: 32737
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 May 2019 15:49:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment