Attention is currently required from: Andrey Pronin, Aseda Aboagye, Julius Werner, Aaron Durbin. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55242 )
Change subject: security/vboot: Add support for ZTE spaces ......................................................................
Patch Set 2:
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55242/comment/02c980b7_bd37179d PS2, Line 16: successfully. Please document how to do that.
Patchset:
PS2: Is successful create logged somehow?
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/55242/comment/727e1f53_1debe4b0 PS2, Line 194: * should be rare (interru pted initialization), so no big harm Stray tab.
https://review.coreboot.org/c/coreboot/+/55242/comment/6d98d087_6e55d819 PS2, Line 263: * Setup the Zero-Touch Enrollment(ZTE) related spaces. Verb is spelled with a space: Set up.
https://review.coreboot.org/c/coreboot/+/55242/comment/012382e1_9462f4c4 PS2, Line 288: VBDEBUG("%s: Failed to setup RMA + SN Bits space\n", __func__); set up
https://review.coreboot.org/c/coreboot/+/55242/comment/bb4e0c45_d89b9697 PS2, Line 292: /* Setup Board ID */ Set up
Comment can be removed, as it’s clear from the code.
https://review.coreboot.org/c/coreboot/+/55242/comment/d7102245_4275b5a5 PS2, Line 298: VBDEBUG("%s: Failed to setup Board ID space\n", __func__); Set up (same below)
https://review.coreboot.org/c/coreboot/+/55242/comment/8222c3f7_d7db64b3 PS2, Line 302: /* Setup RMA Bytes counter */ Set up
https://review.coreboot.org/c/coreboot/+/55242/comment/062abedf_6f6a0522 PS2, Line 308: VBDEBUG("%s: Failed to define RMA Bytes space\n", __func__); Use consistent wording (set up), and RMA Bytes Counter space.
https://review.coreboot.org/c/coreboot/+/55242/comment/1df50965_8dddc04a PS2, Line 352: * these are setup elsewhere via TPM vendor commands. set up