Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35002 )
Change subject: vboot: remove fastboot support
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35002/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35002/1//COMMIT_MSG@8
PS1, Line 8:
Sorry about that! I've added more details.
Done
https://review.coreboot.org/c/coreboot/+/35002/2/src/ec/google/chromeec/swit...
File src/ec/google/chromeec/switches.c:
https://review.coreboot.org/c/coreboot/+/35002/2/src/ec/google/chromeec/swit...
PS2, Line 40:
Is there code in the EC code base we need to get rid of as well? (You can file a bug for the EC folk […]
(edit: wasn't supposed to be a blocking comment)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06ea816ffb910163ec2c3c456b3c09408c806d0b
Gerrit-Change-Number: 35002
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Aug 2019 00:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment