[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Add support to initialize Memory

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39847 )

Change subject: soc/intel/tigerlake: Add support to initialize Memory
......................................................................

Patch Set 21:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39847/21//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39847/21//COMMIT_MSG@7 
PS21, Line 7: Memory
nit: DDR4 memory

https://review.coreboot.org/c/coreboot/+/39847/15/src/soc/intel/tigerlake/in... 
File src/soc/intel/tigerlake/include/soc/meminit_tgl.h:

https://review.coreboot.org/c/coreboot/+/39847/15/src/soc/intel/tigerlake/in... 
PS15, Line 121: vref_ca_config
> Done

So, how would the UPD for this be set? Or is that not required?

https://review.coreboot.org/c/coreboot/+/39847/21/src/soc/intel/tigerlake/me... 
File src/soc/intel/tigerlake/meminit_tgl.c:

https://review.coreboot.org/c/coreboot/+/39847/21/src/soc/intel/tigerlake/me... 
PS21, Line 299: print_spd_info((unsigned char *)blk->spd_array[0]);
              : 	print_spd_info((unsigned char *)blk->spd_array[1]);
              : 	print_spd_info((unsigned char *)blk->spd_array[2]);
              : 	print_spd_info((unsigned char *)blk->spd_array[3]);
Doesn't this end up printing garbage if done unconditionally in case all DIMMs are not populated?

for (i = 0; i < ARRAY_SIZE(blk->addr_map); i++) {
    if (blk->addr_map[i])
         print_spd_info((unsigned char *)blk->spd_array[i]);
}